runtime icon indicating copy to clipboard operation
runtime copied to clipboard

feat: wait for resource to sync before updating

Open michaelhtm opened this issue 6 months ago • 2 comments

Description of changes: Currently, We've been setting a resource as NotSynced in ReadOne, if the resource status is not a certain way (Eg. waiting for EKS Cluster to be Active), and also checking the same resource Status in sdkUpdate.

This is the first attempt at addressing that issue. We are going to need to ensure every controller/resource returns the proper NotSynced reason and the requeue error inside the condition. This will allow us to set a custom requeue right from ReadOne, that will be returned in preUpdate.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

michaelhtm avatar May 22 '25 21:05 michaelhtm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ack-prow[bot] avatar May 22 '25 21:05 ack-prow[bot]

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 55bad60cefa341a2ae1ec7590ece349ae582cb4d link false /test verify-attribution
unit-test 55bad60cefa341a2ae1ec7590ece349ae582cb4d link true /test unit-test
ec2-controller-test 55bad60cefa341a2ae1ec7590ece349ae582cb4d link true /test ec2-controller-test
sagemaker-controller-test 55bad60cefa341a2ae1ec7590ece349ae582cb4d link true /test sagemaker-controller-test
sqs-controller-test 55bad60cefa341a2ae1ec7590ece349ae582cb4d link true /test sqs-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ack-prow[bot] avatar Nov 11 '25 17:11 ack-prow[bot]