runtime
runtime copied to clipboard
aws-controllers-k8s
update: Update the `Resource already exists` condition reason
Description of changes:
Currently the condition reason for the Resource Already Exists
condition message instructs users to adopt the existing resource
using the AdoptResource CRD, which we no longer implement.
This change updates the message to instruct users to instead use the adoption by annotation feature to import an existing resource.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@michaelhtm these test look super flaky, are they related to the previous ec2 change?
@a-hilaly the failing tests are mostly due to eventual consistency..I noticed the more tests we added the worse it got..maybe we can restructure it better
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: a-hilaly, michaelhtm
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [a-hilaly]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![ack-prow[bot] avatar](https://avatars.githubusercontent.com/in/260409?v=4 "Published by a pub.dev verified publisher"){kind=small}
@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| verify-attribution | 578e9af81a327f56cac67ef5bd0865c7a380d3c3 | link | false | /test verify-attribution |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.