runtime
runtime copied to clipboard
aws-controllers-k8s
add `reconcile-reources` flag
Description of changes:
The AWS Controllers for Kubernetes (ACK) service controllers currently initialize reconcilers for all supported resource kinds, regardless of operational needs, leading to unnecessary resource consumption and potential for conflicts. We propose introducing a --reconcile-resources flag that allows operators to specify which resource kinds should be actively reconciled, enabling more efficient resource utilization and operational control. When provided with a comma-separated list of resource kinds (e.g., "Queue,Topic"), the controller will only create reconcilers for those specific resources. This enhancement maintains backward compatibility by continuing to reconcile all resources when the flag is not specified.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: a-hilaly, michaelhtm, rushmash91
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [a-hilaly]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![ack-prow[bot] avatar](https://avatars.githubusercontent.com/in/260409?v=4 "Published by a pub.dev verified publisher"){kind=small}
@rushmash91: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| verify-attribution | 9f6103ef6263c5f8599ac05495dd0152a47cb015 | link | false | /test verify-attribution |
| sagemaker-controller-test | 9f6103ef6263c5f8599ac05495dd0152a47cb015 | link | true | /test sagemaker-controller-test |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.