runtime
runtime copied to clipboard
Filter System tags before patching
Description of changes: This change ensures that neither ACK tags nor AWS tags will be patched.
Sometimes if there's a tag sync issues, these tags get patched to the controller.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: michaelhtm
Once this PR has been reviewed and has the lgtm label, please assign jlbutler for approval by writing /assign @jlbutler in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest
/retest
/retest
@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| verify-attribution | ea14871b4ae4b2c17b710128acbe32ac98a7cc5e | link | false | /test verify-attribution |
| sagemaker-controller-test | ea14871b4ae4b2c17b710128acbe32ac98a7cc5e | link | true | /test sagemaker-controller-test |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
/close :)
/close
@michaelhtm: Closed this PR.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.