runtime
runtime copied to clipboard
Add read-only support for ACK resources via annotation
This commit adds support for making ACK resources read-only via an
annotation. A new services.k8s.aws/read-only annotation can be
added to a resource to instruct the ACK service controller to not
create/patch/delete the underlying AWS resource.
If the annotation is set to true, the controller will:
- return an error on create if the resource doesn't exist
- only patch metadata/spec for updates but not make cloud API calls
- skip deletion of the underlying resource when the k8s resource is deleted
This allows adopting externally managed resources into ACK for read-only purposes like referencing values, without ACK attempting to manage the resource lifecycle.
Signed-off-by: Amine Hilaly [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
/test all
/retest
/test verify-attribution
@a-hilaly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| verify-attribution | 4b439962bcec370a664933b72f865bca3dfce9da | link | false | /test verify-attribution |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: a-hilaly, michaelhtm
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [a-hilaly]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment