runtime
runtime copied to clipboard
Create a seperated CARM map from accounts
Issue #, if available: https://github.com/aws-controllers-k8s/community/issues/2031
Description of changes:
Add a new version the CARM map in parallel of existing ack-role-account-map
Usage:
apiVersion: v1
kind: ConfigMap
metadata:
name: ack-carm-map
namespace: $ACK_SYSTEM_NAMESPACE
data:
owner-account-id/111111111111: arn:aws:iam::111111111111:role/s3FullAccess
If the account ID in ack-carm-map exists, we will use this value. Otherwise, it will use the value in the older version ack-role-account-map .
This will allow the expension to the key of team-id/team-a.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: zicongmei
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @zicongmei. Thanks for your PR.
I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/ok-to-test
Offline discussion:
- rename the configmap to
ack-setting-map - hide it under a feature flag