code-generator
code-generator copied to clipboard
pass optype to setResourceReadMany from SetResource
Description of changes:
Currently, if the resource output shape is a list, code-gen triggers the readmany output generator. When doing so, it does not pass the operationType, which causes it to lose some of its functionality, which in this case was the ability to ignore setting resources for a desired method. With these changes, even sdk outputs that have a list as output type will be able to configure Create/Update/Delete set config in generator.yaml
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: a-hilaly, michaelhtm
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [a-hilaly,michaelhtm]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest
@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| verify-attribution | 0328f60f5c515ed9504861bff6744b4a7ea2d5a2 | link | false | /test verify-attribution |
| s3-olm-test | 0328f60f5c515ed9504861bff6744b4a7ea2d5a2 | link | false | /test s3-olm-test |
| lambda-controller-test | 0328f60f5c515ed9504861bff6744b4a7ea2d5a2 | link | true | /test lambda-controller-test |
| eks-controller-test | 0328f60f5c515ed9504861bff6744b4a7ea2d5a2 | link | true | /test eks-controller-test |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.