code-generator
code-generator copied to clipboard
chore: improve controller build script to pull latest tags
Issue #, if available:
Description of changes: This will ensure we don't accidentally push changes if the PRs are not up to date. Sometimes you would fetch and rebase the changes from upstream, but the tags for some reason always stay behind.
This change ensures the tags are going to be up to date whenever you generate the controller
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: michaelhtm
Once this PR has been reviewed and has the lgtm label, please assign jlbutler for approval by writing /assign @jlbutler in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| verify-attribution | 1508900dc21470b88a8d1e99945582110f90a786 | link | false | /test verify-attribution |
| s3-olm-test | 1508900dc21470b88a8d1e99945582110f90a786 | link | false | /test s3-olm-test |
| documentdb-controller-test | 1508900dc21470b88a8d1e99945582110f90a786 | link | true | /test documentdb-controller-test |
| acm-controller-test | 1508900dc21470b88a8d1e99945582110f90a786 | link | true | /test acm-controller-test |
| cloudfront-controller-test | 1508900dc21470b88a8d1e99945582110f90a786 | link | true | /test cloudfront-controller-test |
| apigatewayv2-controller-test | 1508900dc21470b88a8d1e99945582110f90a786 | link | true | /test apigatewayv2-controller-test |
| dynamodb-controller-test | 1508900dc21470b88a8d1e99945582110f90a786 | link | true | /test dynamodb-controller-test |
| efs-controller-test | 1508900dc21470b88a8d1e99945582110f90a786 | link | true | /test efs-controller-test |
| eventbridge-controller-test | 1508900dc21470b88a8d1e99945582110f90a786 | link | true | /test eventbridge-controller-test |
| ecr-controller-test | 1508900dc21470b88a8d1e99945582110f90a786 | link | true | /test ecr-controller-test |
| eks-controller-test | 1508900dc21470b88a8d1e99945582110f90a786 | link | true | /test eks-controller-test |
| ec2-controller-test | 1508900dc21470b88a8d1e99945582110f90a786 | link | true | /test ec2-controller-test |
| lambda-controller-test | 1508900dc21470b88a8d1e99945582110f90a786 | link | true | /test lambda-controller-test |
| iam-controller-test | 1508900dc21470b88a8d1e99945582110f90a786 | link | true | /test iam-controller-test |
| pipes-controller-test | 1508900dc21470b88a8d1e99945582110f90a786 | link | true | /test pipes-controller-test |
| prometheusservice-controller-test | 1508900dc21470b88a8d1e99945582110f90a786 | link | true | /test prometheusservice-controller-test |
| s3-controller-test | 1508900dc21470b88a8d1e99945582110f90a786 | link | true | /test s3-controller-test |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
/close
@michaelhtm: Closed this PR.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.