aws-cloudformation-resource-providers-codeartifact icon indicating copy to clipboard operation
aws-cloudformation-resource-providers-codeartifact copied to clipboard

KMS Pattern

Open richardhboyd opened this issue 5 years ago • 2 comments
trafficstars

Can you add a pattern for a valid KMS Key Arn? Do you accept Aliases?

https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-codeartifact/blob/master/aws-codeartifact-domain/aws-codeartifact-domain.json#L20

richardhboyd avatar Aug 01 '20 20:08 richardhboyd

we do accept alias:

The encryption key for the domain. This is used to encrypt content stored in a domain. An encryption key can be a key ID, a key Amazon Resource Name (ARN), a key alias, or a key alias ARN

According to api doc, the pattern is Pattern: \S+ , this is already a string type so I'll this like this for now.

jonjara avatar Aug 28 '20 19:08 jonjara

This fees like one of those times where, in the attempt to give developers the most flexibility, we have made it more confusing. By accepting many different types of values, we have precluded the possibility of automated tools to assist customers in defining this. cfn-lint will accept any string, even emojis?

richardhboyd avatar Aug 28 '20 19:08 richardhboyd