amplify-ui icon indicating copy to clipboard operation
amplify-ui copied to clipboard

build: update build to align with the minimum React version

Open zchenwei opened this issue 3 years ago • 1 comments

Description of changes

The current minimum react version we claim to support is 16.8.0. However, the dev version we use to build our library is 17.0.2. This could be problematic since it would introduce some types missing from React 16. Like #2160

Issue #, if available

#2160

Description of how you validated changes

Testing against a sample app running on React 16.8.0, 17 and the latest 18.

Checklist

  • [x] PR description included
  • [ ] yarn test passes
  • [x] No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

zchenwei avatar Aug 30 '22 19:08 zchenwei

⚠️ No Changeset found

Latest commit: fc24e6eb9b0cd31434d6a650a765352b2e4e989c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 30 '22 19:08 changeset-bot[bot]

Closed per discussion offline #2594

zchenwei avatar Oct 07 '22 18:10 zchenwei