amplify-ui icon indicating copy to clipboard operation
amplify-ui copied to clipboard

Border Radius on Authenticator

Open dbanksdesign opened this issue 3 years ago • 6 comments

Before creating a new issue, please confirm:

On which framework/platform are you having an issue?

React, Angular, Vue

Which UI component?

Authenticator

How is your app built?

n/a

Please describe your bug.

Taken from this post in the discussions: https://github.com/aws-amplify/amplify-ui/discussions/198#discussioncomment-1955952

Customer cannot set the border radius of the authenticator, which can be previous done in v1 of the Authenticator. Based on the design and implementation of the new Authenticator, setting a border-radius on an element would not be sufficient because of the style of the sign in/sign up tabs.

What's the expected behaviour?

We should take a look at the Authenticator-specific styling and see if we can make it a bit more flexible and possible add some theme tokens specific to it for styling.

Help us reproduce the bug!

n/a

Code Snippet

No response

Additional information and screenshots

Trying to add a border-radius looks like this:

CleanShot 2022-01-19 at 15 57 34@2x

dbanksdesign avatar Jan 19 '22 23:01 dbanksdesign

Duplicate of #1133

Jesmaster avatar Jan 20 '22 15:01 Jesmaster

I think #1164 should fix it :)

zchenwei avatar Jan 20 '22 18:01 zchenwei

@Jesmaster @zchenwei This issue is slightly different, as it's a feature request from a customer who wants to put a border radius around the entire Authenticator box, not just the Create Account button.

reesscot avatar Jan 21 '22 17:01 reesscot

@Jesmaster @zchenwei This issue is slightly different, as it's a feature request from a customer who wants to put a border radius around the entire Authenticator box, not just the Create Account button.

I see

zchenwei avatar Jan 21 '22 17:01 zchenwei

Here's an example of adding border radius to the Authenticator: https://codesandbox.io/s/authenticator-border-radius-h11beg?file=/src/styles.css

reesscot avatar Jan 31 '23 17:01 reesscot

Here's an example of adding border radius to the Authenticator: https://codesandbox.io/s/authenticator-border-radius-h11beg?file=/src/styles.css

This is a workable solution, thanks. Very much appreciated.

If Amplify change the markup of the authenticator as they do from time to time across versions, then it may break this unofficial fix, of course.

s5b avatar Feb 08 '24 08:02 s5b