amplify-swift icon indicating copy to clipboard operation
amplify-swift copied to clipboard

chore: amplify network package

Open 5d opened this issue 1 year ago • 1 comments

Issue #

Description

  • created a new internal package with name AmplifyNetwork
  • move WebSocketClient module to AmplifyNetwork

General Checklist

  • [x] Added new tests to cover change, if needed
  • [x] Build succeeds with all target using Swift Package Manager
  • [x] All unit tests pass
  • [x] All integration tests pass
  • [ ] Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • [x] Documentation update for the change if required
  • [x] PR title conforms to conventional commit style
  • [ ] New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • [ ] If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

5d avatar Mar 22 '24 21:03 5d

Codecov Report

:x: Patch coverage is 93.10345% with 4 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.38%. Comparing base (d6d5a23) to head (a2cf85a). :warning: Report is 269 commits behind head on main.

Files with missing lines Patch % Lines
.../AppSyncRealTimeClient/AppSyncRealTimeClient.swift 60.00% 2 Missing :warning:
...ubscriptionInterceptor/APIKeyAuthInterceptor.swift 50.00% 1 Missing :warning:
...r/SubscriptionInterceptor/IAMAuthInterceptor.swift 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3583      +/-   ##
==========================================
- Coverage   68.48%   68.38%   -0.10%     
==========================================
  Files        1096     1093       -3     
  Lines       38088    37890     -198     
==========================================
- Hits        26084    25911     -173     
+ Misses      12004    11979      -25     
Flag Coverage Δ
API_plugin_unit_test 70.16% <93.10%> (+1.20%) :arrow_up:
AWSPluginsCore 63.74% <ø> (-1.94%) :arrow_down:
Amplify 48.19% <ø> (ø)
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test 79.46% <ø> (+0.18%) :arrow_up:
CoreMLPredictions_plugin_unit_test 61.15% <ø> (ø)
DataStore_plugin_unit_test 81.40% <ø> (-0.94%) :arrow_down:
Geo_plugin_unit_test 73.50% <ø> (ø)
Logging_plugin_unit_test 62.87% <ø> (ø)
Predictions_plugin_unit_test 37.32% <ø> (ø)
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test 76.75% <ø> (ø)
unit_tests 68.38% <93.10%> (-0.10%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Mar 22 '24 23:03 codecov-commenter