amplify-js icon indicating copy to clipboard operation
amplify-js copied to clipboard

added rekognition customlabels feature to amplify predictions category

Open rpostulart opened this issue 5 years ago • 2 comments

Background: Currently AWS Amplify predictions category is only supporting standard labels from Rekognition. While with custom labels there is a whole new spectrum of Machine Learning that we can add to our client applications. In this change I added the feature to support custom label requests from predictions identify.

Description of changes: I have made a new types for customLabels input and output. There is a check added that when there is a request with the param customlabel that the function identifyCustomLabels is called. This function is an abstraction of identifyLabels.

_Unit test: I am not an expert in creating unit tests. I tried to create a few, but therefor the model needs to run otherwise the test fails. So there is still some work to do to mock this service.

_Repo: here is a react app repo to test the app. Replace the arn with a model arn that you create. https://github.com/rpostulart/customlabelsApp

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

rpostulart avatar Dec 03 '20 08:12 rpostulart

Any updates on this?

rpostulart avatar Dec 07 '20 16:12 rpostulart

Apologizes on not following up on this pull request sooner @rpostulart. We are going to take a look at this and see if this is something we would like to have within the library. @elorzafe or @wlee221 can either of you take a look and see if we need to do a design review for this internally?

sammartinez avatar Oct 27 '21 16:10 sammartinez