amplify-cli icon indicating copy to clipboard operation
amplify-cli copied to clipboard

fix: rework usage data prompt on init

Open aws-eddy opened this issue 2 years ago • 1 comments

Description of changes

This PR moves the usage data prompt on post init to inform developers that we are collecting data to improve the CLI. It also gives them instructions for on how to opt out of this data collection mechanism. This configuration will be stored on a global variable and will only be seen by developers once.

Issue #, if available

Description of how you validated changes

Checklist

  • [x] PR description included
  • [x] yarn test passes
  • [x] Tests are changed or added
  • [ ] Relevant documentation is changed or added (and PR referenced)
  • [ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • [ ] Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

aws-eddy avatar May 30 '23 16:05 aws-eddy

Codecov Report

:x: Patch coverage is 31.25000% with 22 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.43%. Comparing base (ec9a2ba) to head (d9c6771). :warning: Report is 715 commits behind head on dev.

Files with missing lines Patch % Lines
packages/amplify-cli/src/commands/diagnose.ts 23.07% 7 Missing and 3 partials :warning:
...ackages/amplify-cli/src/init-steps/s9-onSuccess.ts 27.27% 8 Missing :warning:
...amplify-cli-core/src/state-manager/stateManager.ts 33.33% 4 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##              dev   #12705       +/-   ##
===========================================
+ Coverage    0.00%   48.43%   +48.43%     
===========================================
  Files        1296      841      -455     
  Lines      149743    38082   -111661     
  Branches     1296     7751     +6455     
===========================================
+ Hits            0    18445    +18445     
+ Misses     148447    18049   -130398     
- Partials     1296     1588      +292     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar May 31 '23 21:05 codecov-commenter