amplify-cli icon indicating copy to clipboard operation
amplify-cli copied to clipboard

fix: added extra case when local env function has secrets

Open akshbhu opened this issue 2 years ago • 2 comments

Description of changes

  • moved prePush and verification on env parameters after env init and before deploy
  • handling function secrets when checking out environments

Issue #10764

Description of how you validated changes

  • added unit test
  • added e2e test
  • manual testing

Checklist

  • [x] PR description included
  • [x] yarn test passes
  • [x] Tests are changed or added
  • [ ] Relevant documentation is changed or added (and PR referenced)
  • [ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • [ ] Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

akshbhu avatar May 16 '23 17:05 akshbhu

Codecov Report

:x: Patch coverage is 40.00000% with 27 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.41%. Comparing base (ec9a2ba) to head (e4a3e0b). :warning: Report is 715 commits behind head on dev.

Files with missing lines Patch % Lines
...n/src/utils/ssm-utils/env-parameter-ssm-helpers.ts 10.00% 18 Missing :warning:
packages/amplify-category-function/src/index.ts 57.14% 4 Missing and 2 partials :warning:
...meters/src/backend-config-parameters-controller.ts 0.00% 2 Missing :warning:
...ckages/amplify-environment-parameters/src/index.ts 0.00% 1 Missing :warning:

:x: Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev   #12631       +/-   ##
===========================================
+ Coverage    0.00%   48.41%   +48.41%     
===========================================
  Files        1296      841      -455     
  Lines      149743    38117   -111626     
  Branches     1296     7758     +6462     
===========================================
+ Hits            0    18455    +18455     
+ Misses     148447    18070   -130377     
- Partials     1296     1592      +296     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar May 19 '23 21:05 codecov-commenter

@akshbhu this PR has a merge conflict

jhockett avatar May 25 '23 18:05 jhockett