amplify-cli icon indicating copy to clipboard operation
amplify-cli copied to clipboard

fix: yarn/pnpm uninstall removes binary

Open josefaidt opened this issue 2 years ago • 2 comments
trafficstars

Description of changes

  • adds uninstall npm script to run rimraf $HOME/.amplify/bin/amplify to remove local binary when running pnpm uninstall --global @aws-amplify/cli
  • modifies amplify uninstall to uninstall using the package manager amplify was called with

removes need for running amplify uninstall; pnpm rm -g @aws-amplify/cli to uninstall

Issue #, if available

#10610

Description of how you validated changes

Checklist

  • [x] PR description included
  • [x] yarn test passes
  • [x] Tests are changed or added
  • [ ] Relevant documentation is changed or added (and PR referenced)
  • [ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • [ ] Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

josefaidt avatar Mar 23 '23 00:03 josefaidt

I'm not too sure where to add tests for this but happy to add them

josefaidt avatar Mar 23 '23 00:03 josefaidt

Codecov Report

Merging #12292 (e2497b0) into dev (984c0f8) will decrease coverage by 2.37%. The diff coverage is 55.66%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev   #12292      +/-   ##
==========================================
- Coverage   49.45%   47.08%   -2.37%     
==========================================
  Files         692      836     +144     
  Lines       33424    38030    +4606     
  Branches     6840     7712     +872     
==========================================
+ Hits        16529    17908    +1379     
- Misses      15370    18484    +3114     
- Partials     1525     1638     +113     
Impacted Files Coverage Δ
...mplify-appsync-simulator/src/resolvers/function.ts 15.38% <ø> (ø)
...s/amplify-appsync-simulator/src/type-definition.ts 100.00% <ø> (ø)
...sync-simulator/src/velocity/util/dynamodb-utils.ts 6.55% <0.00%> (ø)
...y-appsync-simulator/src/velocity/util/map-utils.ts 10.00% <ø> (ø)
...tor/src/velocity/util/transform/dynamodb-filter.ts 4.93% <0.00%> (ø)
...appsync-simulator/src/velocity/value-mapper/map.ts 86.88% <ø> (ø)
...ackages/amplify-category-auth/src/commands/auth.ts 0.00% <0.00%> (ø)
...es/amplify-category-auth/src/commands/auth/help.ts 0.00% <0.00%> (ø)
.../amplify-category-auth/src/commands/auth/import.ts 0.00% <0.00%> (ø)
...dformation/auth-inputs-manager/auth-input-state.ts 46.93% <0.00%> (ø)
... and 101 more

... and 458 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Mar 23 '23 00:03 codecov-commenter