amplify-cli icon indicating copy to clipboard operation
amplify-cli copied to clipboard

fix: enable amplify-appsync-simulator time utilities to take Java par…

Open tbartley opened this issue 3 years ago • 1 comments

…ameters

Description of changes

Enable amplify-appsync-simulator $util.time emulated routines to take Java* parameters as well as regular JavaScript parameters.

Issue #, if available

803

Description of how you validated changes

I added unit tests for new cases and verified unit tests for existing functionality continue to pass. I also verified the build against my own project to verify the issue I observed was resolved in the environment I discovered it.

Checklist

  • [X] PR description included
  • [X] yarn test passes
  • [X] Tests are or added (https://github.com/aws-amplify/amplify-cli/blob/dev/CONTRIBUTING.md#tests)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

tbartley avatar Sep 20 '22 05:09 tbartley

Codecov Report

Merging #11032 (e093f87) into dev (ac31ec0) will increase coverage by 0.03%. The diff coverage is 95.00%.

@@            Coverage Diff             @@
##              dev   #11032      +/-   ##
==========================================
+ Coverage   48.19%   48.23%   +0.03%     
==========================================
  Files         670      670              
  Lines       32446    32458      +12     
  Branches     6598     6598              
==========================================
+ Hits        15638    15656      +18     
+ Misses      15188    15184       -4     
+ Partials     1620     1618       -2     
Impacted Files Coverage Δ
...mplify-appsync-simulator/src/velocity/util/time.ts 88.67% <95.00%> (+15.50%) :arrow_up:
...li/src/domain/amplify-usageData/getUsageDataUrl.ts 100.00% <0.00%> (+12.50%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 20 '22 05:09 codecov-commenter

No worries and thanks for approving! Are the check failures anything I need to look at resolving?

tbartley avatar Nov 24 '22 00:11 tbartley

@tbartley thank you for your contribution! I'm looking to merge this right now. Would you be able to resolve the merge conflicts so I can merge?

Amplifiyer avatar Feb 01 '23 13:02 Amplifiyer