amplify-cli icon indicating copy to clipboard operation
amplify-cli copied to clipboard

CLI should use the same .ini / config parser as the rest of AWS

Open awsluja opened this issue 3 years ago • 1 comments
trafficstars

Is this feature request related to a new or existing Amplify category?

auth, storage, api, hosting

Is this related to another service?

No response

Describe the feature you'd like to request

The Amplify CLI currently uses this parser for config & credential files: https://github.com/npm/ini It should be using the shared ini parser provided by the AWS SDK: https://github.com/aws/aws-sdk-js/blob/master/lib/shared-ini/index.js

There are several open issues related to the differences between the Amplify CLI and other AWS tools using the shared config/credentials files. #10525 #2441 #1245

Describe the solution you'd like

Migrate to using the ini parser that is used by the rest of the AWS JS ecosystem.

Describe alternatives you've considered

There are other publicly available ini parsers but we should stick to the AWS ini parser.

Additional context

No response

Is this something that you'd be interested in working on?

  • [X] 👋 I may be able to implement this feature request

Would this feature include a breaking change?

  • [ ] ⚠️ This feature might incur a breaking change

awsluja avatar Sep 19 '22 18:09 awsluja

I have a fix in the works for this

aws-eddy avatar Sep 20 '22 20:09 aws-eddy

After further investigation, I have found that the ini parser on aws-sdk-js is not meant to be consumed. Furthermore, it does not have the same methods as the npm ini parser that we are currently using. So we cannot use this aws-sdk ini parser. Closing this issue for now.

aws-eddy avatar Sep 22 '22 18:09 aws-eddy