amplify-cli
amplify-cli copied to clipboard
feat: add console command to storage category
Implements amplify storage console command.
Description of changes
Issue #, if available
fix #9900
Description of how you validated changes
Checklist
- [x] PR description included
- [x]
yarn testpasses - [x] Tests are changed or added
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Codecov Report
Merging #10981 (2fefad9) into dev (3c39eba) will increase coverage by
0.03%. The diff coverage is64.70%.
@@ Coverage Diff @@
## dev #10981 +/- ##
==========================================
+ Coverage 47.82% 47.85% +0.03%
==========================================
Files 669 670 +1
Lines 32678 32719 +41
Branches 6608 6614 +6
==========================================
+ Hits 15627 15659 +32
- Misses 15419 15428 +9
Partials 1632 1632
| Impacted Files | Coverage Δ | |
|---|---|---|
| packages/amplify-category-storage/src/index.ts | 28.12% <52.00%> (+4.67%) |
:arrow_up: |
| ...rage/src/provider-utils/awscloudformation/index.ts | 29.24% <75.00%> (+12.37%) |
:arrow_up: |
| ...y-category-storage/src/commands/storage/console.ts | 100.00% <100.00%> (ø) |
|
| ...li/src/domain/amplify-usageData/getUsageDataUrl.ts | 100.00% <0.00%> (+12.50%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@edwardfoyle Thank you for your review. I fixed according to your suggestions.
@edwardfoyle I fixed according to your addition suggestions. Could you review this RP again ?
@edwardfoyle Is this RP has blockers? Is there anything I can do to get my PR reviewed? Thanks.
@edwardfoyle I fixed according to your addition suggestions. Could you review this RP again ?
@jhockett Thank you for your review. I corrected it in accordance with your suggestions.
This looks good to me. I do see that the verify-extract-api test is failing. Can you please run yarn clean && yarn dev-build && yarn extract-api and then push to your branch to fix the issue?
@goldbez Thanks. I run yarn clean && yarn dev-build && yarn extract-api and then push it.
@goldbez Thanks. I run
yarn clean && yarn dev-build && yarn extract-apiand then push it.
Thank you
Running E2E tests: https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli?branch=run-e2e/goldbez/feat/storage-console-command
Thank you for your contribution, @fossamagna