amplify-cli icon indicating copy to clipboard operation
amplify-cli copied to clipboard

feat: add console command to storage category

Open fossamagna opened this issue 3 years ago • 2 comments
trafficstars

Implements amplify storage console command.

Description of changes

Issue #, if available

fix #9900

Description of how you validated changes

Checklist

  • [x] PR description included
  • [x] yarn test passes
  • [x] Tests are changed or added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

fossamagna avatar Sep 07 '22 14:09 fossamagna

Codecov Report

Merging #10981 (2fefad9) into dev (3c39eba) will increase coverage by 0.03%. The diff coverage is 64.70%.

@@            Coverage Diff             @@
##              dev   #10981      +/-   ##
==========================================
+ Coverage   47.82%   47.85%   +0.03%     
==========================================
  Files         669      670       +1     
  Lines       32678    32719      +41     
  Branches     6608     6614       +6     
==========================================
+ Hits        15627    15659      +32     
- Misses      15419    15428       +9     
  Partials     1632     1632              
Impacted Files Coverage Δ
packages/amplify-category-storage/src/index.ts 28.12% <52.00%> (+4.67%) :arrow_up:
...rage/src/provider-utils/awscloudformation/index.ts 29.24% <75.00%> (+12.37%) :arrow_up:
...y-category-storage/src/commands/storage/console.ts 100.00% <100.00%> (ø)
...li/src/domain/amplify-usageData/getUsageDataUrl.ts 100.00% <0.00%> (+12.50%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 13 '22 03:09 codecov-commenter

@edwardfoyle Thank you for your review. I fixed according to your suggestions.

fossamagna avatar Sep 14 '22 00:09 fossamagna

@edwardfoyle I fixed according to your addition suggestions. Could you review this RP again ?

fossamagna avatar Oct 12 '22 14:10 fossamagna

@edwardfoyle Is this RP has blockers? Is there anything I can do to get my PR reviewed? Thanks.

fossamagna avatar Nov 04 '22 14:11 fossamagna

@edwardfoyle I fixed according to your addition suggestions. Could you review this RP again ?

fossamagna avatar Dec 22 '22 13:12 fossamagna

@jhockett Thank you for your review. I corrected it in accordance with your suggestions.

fossamagna avatar Dec 28 '22 14:12 fossamagna

This looks good to me. I do see that the verify-extract-api test is failing. Can you please run yarn clean && yarn dev-build && yarn extract-api and then push to your branch to fix the issue?

goldbez avatar Jan 11 '23 22:01 goldbez

@goldbez Thanks. I run yarn clean && yarn dev-build && yarn extract-api and then push it.

fossamagna avatar Jan 12 '23 00:01 fossamagna

@goldbez Thanks. I run yarn clean && yarn dev-build && yarn extract-api and then push it.

Thank you

goldbez avatar Jan 12 '23 23:01 goldbez

Running E2E tests: https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli?branch=run-e2e/goldbez/feat/storage-console-command

goldbez avatar Jan 12 '23 23:01 goldbez

Thank you for your contribution, @fossamagna

goldbez avatar Jan 13 '23 21:01 goldbez