amplify-category-api icon indicating copy to clipboard operation
amplify-category-api copied to clipboard

fix: lint script to emit error

Open AaronZyLee opened this issue 2 years ago • 1 comments
trafficstars

Description of changes

Fix the issue of lint error not emitting

CDK / CloudFormation Parameters Changed

Issue #, if available

Description of how you validated changes

Checklist

  • [x] PR description included
  • [x] yarn test passes
  • [ ] Tests are changed or added
  • [ ] Relevant documentation is changed or added (and PR referenced)
  • [ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • [ ] Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AaronZyLee avatar Jul 12 '23 21:07 AaronZyLee

I've tested this with a couple of open PRs.

  1. Has JS/TS files to lint: curl -fsSL https://api.github.com/repos/aws-amplify/amplify-category-api/pulls/2666/files | jq -r '.[] | select(.status!="removed") | .filename' | grep -E '\.(js|jsx|ts|tsx)$' | xargs yarn eslint || true
  2. Does not have JS/TS files to lint: curl -fsSL https://api.github.com/repos/aws-amplify/amplify-category-api/pulls/1665/files | jq -r '.[] | select(.status!="removed") | .filename' | grep -E '\.(js|jsx|ts|tsx)$' | xargs yarn eslint || true

dpilch avatar Jul 02 '24 16:07 dpilch