amplify-backend icon indicating copy to clipboard operation
amplify-backend copied to clipboard

Add minify option to defineFunction

Open fossamagna opened this issue 1 year ago • 2 comments

Problem

Issue number, if available:

#2027

Changes

  1. Add minify option to defineFunction. Default value is true.

Corresponding docs PR, if applicable:

Validation

Added test.

Checklist

  • [ ] If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • [ ] If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • [ ] If this PR requires a docs update, I have linked to that docs PR above.
  • [ ] If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

fossamagna avatar Oct 09 '24 16:10 fossamagna

🦋 Changeset detected

Latest commit: 9749fe0f9def16e6aba502843d85c86c3ddb287b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@aws-amplify/backend-function Minor
@aws-amplify/backend Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 09 '24 16:10 changeset-bot[bot]

Also. I have ran the e2e test suite for this PR here https://github.com/aws-amplify/amplify-backend/actions/runs/11278596582/job/31367743355 .

There's one error that needs a fix: image

Could you please include new function in this directory https://github.com/aws-amplify/amplify-backend/tree/main/packages/integration-tests/src/test-projects/data-storage-auth-with-triggers-ts/hotswap-update-files ? These files are used to update test project, if function is not included there it gets deleted before assertions run.

sobolk avatar Oct 10 '24 17:10 sobolk