amplify-backend
amplify-backend copied to clipboard
[POC] Attempt to use data and auth as stack providers for function. This won't work.
Problem
Certain usage patterns of functions end up with Caused By: ❌ Deployment failed: Error [ValidationError]: Circular dependency between resources:.
This happens is scenarios where it could have been avoided. Just because we pack all functions into same stack and therefore coupling them together.
Changes
This PR is a failed attempt to make auth and data a "donor" of stack/scope.
At some point I realized that such design will be deemed to fail in generic case. I.e. it would create cyclic compile time problem, where writing an elegant code that would compile is just impossible. See here.
This perhaps could be further explored by adding "post defineX" APIs. I.e. by exposing additional mutators on construct factories (like func.useScopeOf(data) or so).
Validation
There are two test projects used to reproduce the original problem:
test-projects/function-stack-1test-projects/function-stack-2
Both deployed successfully with new setting.
Checklist
- [ ] If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
- [ ] If this PR requires a change to the Project Architecture README, I have included that update in this PR.
- [ ] If this PR requires a docs update, I have linked to that docs PR above.
- [ ] If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the
run-e2elabel set.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
⚠️ No Changeset found
Latest commit: 92214735348917330dad263b90298af1d15f218d
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR