amplify-backend icon indicating copy to clipboard operation
amplify-backend copied to clipboard

Build notifications have unescaped url

Open cedWetzel opened this issue 1 year ago • 1 comments

Environment information

General

Describe the bug

We have amplify branch deployments and their build notifications enabled. When pushing branches like feature/cool-thing, the deployment URL is something like https://feature-cool-thing.[appid].amplifyapp.com

The build notification states

Build notification from the AWS Amplify Console for app: https://feature/cool-thing.du3jckf[...].amplifyapp.com/.

Instead the branch name should be dash encoded

Reproduction steps

  1. Create amplify app
  2. setup build notifications
  3. push a branch with "/" in it
  4. receive wrongly formatted build notification

cedWetzel avatar Aug 29 '24 18:08 cedWetzel