configure-aws-credentials icon indicating copy to clipboard operation
configure-aws-credentials copied to clipboard

Published 20 hours ago • verified publisher icon aws-actions

Don't hide account ID in Actions logs by default

Open danielcompton opened this issue 3 years ago • 1 comments

Description of changes:

According to https://www.lastweekinaws.com/blog/are-aws-account-ids-sensitive-information/ which was confirmed with AWS:

“Account IDs are not considered sensitive. Based on your feedback, we’ve started updating our documentation to make this more clear.”

This commit updates the 'mask-aws-account-id' input to default to 'false' if it is not provided.

I'm not sure whether this should be considered a breaking change or not? It is changing the contract, but I don't think in a security sensitive way. I could see other interpretations though.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Fixes https://github.com/aws-actions/configure-aws-credentials/issues/459

danielcompton avatar Mar 27 '22 10:03 danielcompton

AWS account ID A 12-digit number, such as 123456789012, that uniquely identifies an AWS account. Account IDs are not considered sensitive information.

Extracted from: https://docs.aws.amazon.com/general/latest/gr/acct-identifiers.html

oliverhr avatar Aug 02 '22 23:08 oliverhr

Hey all, and thanks Daniel for the contribution, it's much appreciated.

I'm going to close this for the reason stated in #459. Look forward to the next major version release to see this functionality changed!

peterwoodworth avatar Oct 04 '22 20:10 peterwoodworth