aws-codebuild-run-build icon indicating copy to clipboard operation
aws-codebuild-run-build copied to clipboard

Support Disabling Source Type Override Parameters

Open khola opened this issue 4 years ago • 4 comments

Issue #, if available: https://github.com/aws-actions/aws-codebuild-run-build/issues/57

Description of changes: Added additional input to allow for disabling the parameters sourceTypeOverride and sourceLocationOverride. Test cases added.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • [] Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

khola avatar Apr 09 '21 10:04 khola

Thank you for working on this and submitting this pull request. We want this so we can use s3 as a source instead of GitHub. However, when testing your changes, s3 as a source fails with the following error: "Source version should be empty for S3 folder source location". The sourceVersion also needs to be left unset in order to get s3 to work as a source.

pavlovecjakePFG avatar Apr 28 '21 20:04 pavlovecjakePFG

May I ask why this is not merged ? I need this feature very much in my project

mostmentor avatar Feb 21 '22 02:02 mostmentor

Is it going to be merged? I just want GitHub actions to trigger CodeBuild to run build commands in VPC. It doesn't need a source of GITHUB

smailc avatar May 26 '22 20:05 smailc

@smailc I actually forked and tweaked it to do this https://github.com/mostmentor/aws-codebuild-run-build

mostmentor avatar May 27 '22 00:05 mostmentor

close this in favor of https://github.com/aws-actions/aws-codebuild-run-build/pull/102

taoyong-ty avatar Jan 31 '23 23:01 taoyong-ty