amazon-ecs-render-task-definition icon indicating copy to clipboard operation
amazon-ecs-render-task-definition copied to clipboard

Published 20 hours ago • verified publisher icon aws-actions

feat: add possibility to add more than one container in container-name

Open felipem1210 opened this issue 2 years ago • 3 comments

Issue #, if available: https://github.com/aws-actions/amazon-ecs-render-task-definition/issues/228

Description of changes:

In this PR I'm adding the possibilty to pass more than one container inside container-name input. The container names can be passed comma separated. The same image and environment variables will be applied to all the containers

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

felipem1210 avatar Feb 06 '23 09:02 felipem1210

Just want to say, can't wait for this feature to be merged in, it's going to be particularly helpful!

DragosDumitrache avatar Feb 13 '24 11:02 DragosDumitrache

Hi @felipem1210, thank you so much for your contribution. Apologies on the delay. We will be working on reviewing Pull Requests on the repositories. In the mean time please ensure that below steps, if not already done, are taken care of in your PR:

  1. Verify if PR follows semantic pull request conventions.

  2. Please run npm run package command to update dist/ folder with latest dependencies.

  3. Resolve merge conflicts on the PR if any.

amazreech avatar May 10 '24 19:05 amazreech

@amazreech I was totally unaware that you had reviewed this PR, I just have resolved the conflicts, glad to know that there is people still maintaining this project

felipem1210 avatar Oct 02 '24 14:10 felipem1210

@amazreech Hi 👋 . Is there an update on this?

davidhernandez-asurion avatar Nov 25 '24 21:11 davidhernandez-asurion

@amazreech Still needed—would be great to see this implemented! 🙂

yngvark avatar Mar 14 '25 09:03 yngvark

Maybe one day in the year 3025 somebody of the maintainers can merge this PR

felipem1210 avatar Mar 23 '25 10:03 felipem1210

anyone still waiting to get merged in 2025?

Klassikcat avatar Apr 10 '25 06:04 Klassikcat

Still waiting here in 2027.

alexw23 avatar Apr 10 '25 11:04 alexw23

Clearly plenty of support for this PR to be merged. Come on repo owners, do something about it!

Sincerely someone who has been waiting for this to be merged for 2 years now.

yordaa-me avatar Jun 19 '25 12:06 yordaa-me

@jirkafajfr @kellertk @lehmanmj @madsid @matteofigus @mattsb42-aws @s-kenji @serresebastien @ThirdEyeSqueegee

Can one of you help us please, by taking a look at this PR?

fardin01 avatar Aug 07 '25 15:08 fardin01

@greyshi @kg-aws @taoyong-ty

Can one of you help us please, by taking a look at this PR? Thank you.

fardin01 avatar Aug 13 '25 09:08 fardin01

Thank you for your contributions and your patience. We have merged in this PR and it should be available in the latest release tagged v1.8.0

s3cube avatar Aug 14 '25 22:08 s3cube

Finally!!!

Klassikcat avatar Aug 26 '25 02:08 Klassikcat