edd-themedd
edd-themedd copied to clipboard
Add action hooks to themedd_colors_output_customizer_styling function
For child theme developers, it would be useful to have action hooks before and after the main themedd_colors_output_customizer_styling output section to allow additional elements to be styled during the routine without re-writing a similar function in the child theme itself.
Submitted PR #165 in relation to this!
@davidsherlock Thanks, we could probably get away with only having 1 action hook at the bottom. I don't see a need for two if it's purely to be able to choose a location.
I'd prefer though if we hold on doing this for the time being, at least until https://github.com/easydigitaldownloads/themedd/issues/88 is done and dusted. There's a few bugs with the customizer and I'm not sure at this point if things are going to drastically change.
Sure, I understand!
I picked two hooks on purpose however, due to the potential for rules to be overwritten by other more general selectors within the styling. Being able to control the order is important for more generic rules.
Regardless, I’m happy with what you think is best!
Sent from my iPhone
On 21 Oct 2017, at 02:27, Andrew Munro [email protected] wrote:
@davidsherlock Thanks, we could probably get away with only having 1 action hook at the bottom. I don't see a need for two if it's purely to be able to choose a location.
I'd prefer though if we hold on doing this for the time being, at least until #88 is done and dusted. There's a few bugs with the customizer and I'm not sure at this point if things are going to drastically change.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.