avo Remove `OpenStruct` from the codebase

Remove `OpenStruct` from the codebase

Open adrianthedev opened this issue 1 year ago • 5 comments

OpenStruct seems to be "deprecated" and not that performant. Let's try to replace it with Data (carefull. it's not mutable).

Sep 14 '24 07:09 adrianthedev

hi @adrianthedev would you be okay assigning this to me .

Sep 23 '24 10:09 Yash-Singh-Pathania

Done! Thanks @Yash-Singh-Pathania!

Sep 23 '24 10:09 adrianthedev

Maybe this is a good alternative? https://api.rubyonrails.org/classes/ActiveSupport/OrderedOptions.html

Oct 01 '24 14:10 adrianthedev

@adrianthedev Makes sense. I'll try to implement it and have the pull request ready by today or the day after. Thanks for the help!

Oct 02 '24 10:10 Yash-Singh-Pathania

@adrianthedev : https://github.com/avo-hq/avo/actions/runs/11178246617/job/31075442563?pr=3307 could you please help me with the test cases ?

Oct 04 '24 10:10 Yash-Singh-Pathania