bashttpd icon indicating copy to clipboard operation
bashttpd copied to clipboard

I removed the date command

Open m42a opened this issue 13 years ago • 6 comments

m42a avatar Sep 17 '12 01:09 m42a

Can you merge your changes with the latest code please, and fix the cut? I'd love to merge this :-)

avleen avatar Sep 20 '12 03:09 avleen

Actually, with the new architecture, everything but the date stuff is fixed already. The current version should only have the date bits changed (and I think this'll work on older versions of bash).

m42a avatar Sep 20 '12 11:09 m42a

Several things:

  • I like the creative use of printf here for the date. We should pull this in.
  • I'm not so sure about the stat change. It's complicated, and inefficient since it has to read the entire file into memory.
  • Could you please provide a branch with cleaner history for pulling? Merging your master branch will include all of your intermediate commits into the project, and they are really not relevant. I'd suggest creating a new branch and cherry-picking the printf change, and re-submitting the pull request.

ghost avatar Sep 21 '12 00:09 ghost

Have you tested printf with bash 3.2? I just don't want to issue another request that won't work for avleen.

And Re: the stat change, I'll agree it's inefficient (although not majorly so; it takes less than half a second to size-check a 700K text file) but not for that reason; we have to read the entire file into memory anyway since we're serving it up.

m42a avatar Sep 21 '12 01:09 m42a

What's wrong with using stat? I'd much rather use something that's O(1) rather than O(n) to calculate length. (Note that I also tested using bash's built-in strlen with ${#content}, and it is slower than wc for files of any appreciable size.)

ab avatar Sep 21 '12 01:09 ab

Nothing is wrong with stat, but it's not built into bash (or guaranteed to exist at all, in fact).

m42a avatar Sep 21 '12 01:09 m42a