redd icon indicating copy to clipboard operation
redd copied to clipboard

Added Submission::link and Comment::comment_link

Open khalilfazal opened this issue 7 years ago • 4 comments
trafficstars

The method names are confusing. Why does Submission::permalink return a relative path instead of an absolute path? Why does Comment::link return the link to the submission instead of a link to the comment itself?

khalilfazal avatar Jun 30 '18 19:06 khalilfazal

So I don't think it's my fault that travis can't build. It is having trouble installing jruby.

khalilfazal avatar Jun 30 '18 19:06 khalilfazal

Reddit calls a submission also a link. Please suffix your functions with _url instead of _link.

StephanMeijer avatar Aug 28 '18 10:08 StephanMeijer

Maybe change to other link-function to url as well?

StephanMeijer avatar Aug 28 '18 13:08 StephanMeijer

Thank you. I will merge it into my fork (https://github.com/StephanMeijer/redd/)

StephanMeijer avatar Aug 29 '18 14:08 StephanMeijer