react-leaflet-kml icon indicating copy to clipboard operation
react-leaflet-kml copied to clipboard

NPM Could not resolve dependency when using React 17

Open jpmc3630 opened this issue 4 years ago • 5 comments

Hey thanks for your work on the package.

I was wondering if you will be soon bumping the peer dependency to React version 17.

npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.0" from [email protected]

Thanks

jpmc3630 avatar Nov 17 '21 09:11 jpmc3630

@jpmc3630 Hi,

I released version 2.0.3 which allows any react version equals or higher than 16.8.0.

aviklai avatar Nov 17 '21 21:11 aviklai

Still open as the target moves. Right now react-leaflet-kml has

peer react-leaflet@"^3.0.0" from [email protected]

But the current react-leaflet is react-leaflet@"^4.0.0" which supports react 18.2.0 (not 17) which is what all my code is on.

Any plans to bump react-leaflet-kml to react-leaflet@^4.0.0 in the near future? Or is this something you can point me toward doing? I think react-leaflet-kml is the ticket for me, I've spent a lot of time trying to get common JS KML stuff to work in React.

sammyjava avatar Jun 17 '22 04:06 sammyjava

@sammyjava Hi,

I have added support for leaflet 1.8.0, react leaflet 4 and react 18. You can try version 2.0.4. You can check the codesandbox example that uses leaflet 1.8.0 and react 18: https://codesandbox.io/s/basic-usage-react-leaflet-v3-pzcvt

aviklai avatar Jun 17 '22 12:06 aviklai

Thank you so much! This is great! I'll give you attribution on the site. You rock!

sammyjava avatar Jun 17 '22 16:06 sammyjava

May have to thin them out a bit... :) (Gasoline stations with ethanol-free gas, from pure-gas.org)

image

sammyjava avatar Jun 17 '22 16:06 sammyjava