avarayr

Results 30 comments of avarayr

Thank you for this @pimterry and thank you for this amazing well-tested library. I ended up forking and hacking up a solution that fit my usecase, here's how I did...

I also had to write a custom `decodeBodyStream` function because I couldn't find support for it in the `@httptoolkit/http-encoding` request-utils.ts ```typescript export function decodeBodyStream(stream: stream.Readable, headers: Headers | RawHeaders) {...

> Meta doesn't contain any memory referenced by anyone. This could use a test too to demonstrate the fix. Thanks for the review. As my understanding is, the crash wasn’t...

Ah, looks like I was fighting with a symptom here. Closing this in favor of #9722—thanks for fixing it!

> I don't know or think #9722 fixes it. That fixes a problem, but I'm still able to get #9721 hmm, fwiw i just pulled #9722 and tested `yes` +...

Yup, you're right, I spoke too soon. Crash happens sporadically even with #9722. somewhat consistent repro on 9722 is run `yes` + search for `yes` + backspace backspace --- On...

Great news everyone, `1.9.0-pre.1.patch.0` is available via Nightly which fixes the issue! Big thanks to @tmm1 and Cursor Team. [The hotfix via `koffi`](https://github.com/electron/electron/pull/48376#issuecomment-3420476153) is first of its kind and I've...

Spoke too soon, this fix is gated to 25.0.* only for some reason. This bug exists in MacOS Kernel version 25.0.* and 25.1.* Come on guys :(

> Good catch. It does work on latest stable Tahoe though, that's where we tested it. > > ``` > > parseFloat('25.0.1') > 25 > > parseFloat('25.1.1') > 25.1 >...

> Cursor 2.0.40 still seems to list Electron 34.5.8, so I'm a little skeptical that this is fixed, unless the Electron version number was not updated? 🤔 > > It's...