Add `no-invalid-modifier-chain` rule

[KinectTheUnknown]

No Invalid Modifier Chain

Fixes #186

Description

Disallows invalid combinations, order, and name of test/hook modifiers

Progress:

• [x] Detect invalid modifiers
  • [x] Name
  • [x] Order
  • [x] Combination
• [ ] More detailed errors
  • [ ] Conflicting modifiers
  • [ ] Order
• [ ] Provide possible options to fix invalid modifiers
  • [ ] Mispellings
  • [ ] Order
  • [ ] Combinations
• [ ] ~~Configurable Options~~
  • [ ] ~~Whitelist modifier names from being flagged~~ Too complicated to implement at this time
• [ ] Properly deprecate rules (note: Properly deprecated rules aren't supported by package tests)
  • [ ] no-duplicate-modifiers
  • [ ] no-unknown-modifiers

References:

🦄

---

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

• #186: Restrict modifier chaining

---

[novemberborn]

Impressive start @KinectTheUnknown!

What kind of feedback are you looking for at this stage?

[KinectTheUnknown]

Impressive start @KinectTheUnknown!

What kind of feedback are you looking for at this stage?

I just wanted to make sure that I'm on the right path as far as the goals and features of this rule and anything else that this rule should cover.

Right now, I'm making several changes to make error messages more specific so I can implement suggestions/fixes.

[novemberborn]

I just wanted to make sure that I'm on the right path as far as the goals and features of this rule and anything else that this rule should cover.

Yea I think so!

[sindresorhus]

@KinectTheUnknown Still interested in finishing this?

[KinectTheUnknown]

@KinectTheUnknown Still interested in finishing this?

Yes