dependency-analysis-gradle-plugin icon indicating copy to clipboard operation
dependency-analysis-gradle-plugin copied to clipboard

Prevent project is already evaluated error

Open Artemych opened this issue 3 years ago • 4 comments
trafficstars

Please take a look at the issue #435

For some mutlimodule projects usage of that plugin could not be possible as users receives an error like: "Cannot run Project.afterEvaluate(Action) when the project is already evaluated" during the project sync.

It could be caused by manipulating with the evaluation order. To prevent that we have to check the current internal project state.

Artemych avatar Jan 26 '22 10:01 Artemych

I can't merge this without a regression test. Could you provide detailed steps on how I'd set up a project so that this would be necessary?

autonomousapps avatar Jan 28 '22 23:01 autonomousapps

I can't merge this without a regression test. Could you provide detailed steps on how I'd set up a project so that this would be necessary?

regression pipeline is passed.

About the steps: In our project we have some logic with the evaluation order like here. Hope these description will be enough.

Artemych avatar Jan 29 '22 06:01 Artemych

I appreciate you keeping your branch up to date. Unfortunately, I haven't had time to write a test on behalf of this change. Is that something you'd be interested in doing? I'm willing to offer guidance.

autonomousapps avatar Feb 08 '22 00:02 autonomousapps

I appreciate you keeping your branch up to date. Unfortunately, I haven't had time to write a test on behalf of this change. Is that something you'd be interested in doing? I'm willing to offer guidance.

Trying to do my best to add the test for that particular case. For now unfortunately I haven't time but hope i will do that by the end of the week.

Artemych avatar Feb 08 '22 06:02 Artemych