dependency-analysis-gradle-plugin icon indicating copy to clipboard operation
dependency-analysis-gradle-plugin copied to clipboard

Remove code specific to Gradle < 8.0

Open MGaetan89 opened this issue 1 year ago • 3 comments
trafficstars

According to the following link, AGP 8.0 (which is the minimum supported version by this plugin) requires at least Gradle 8.0. https://developer.android.com/build/releases/gradle-plugin#updating-gradle

This PR removes all the code specific to Gradle versions below 8.0.

@autonomousapps if I missed something, and these changes should be reverted, let me know.

MGaetan89 avatar Aug 14 '24 12:08 MGaetan89

There's a failing functional JVM test:

AbiExclusionsSpec > can exclude custom source set from ABI analysis (#gradleVersion) > can exclude custom source set from ABI analysis (Gradle 8.0) FAILED
    org.spockframework.runtime.ConditionFailedWithExceptionError at AbiExclusionsSpec.groovy:37
        Caused by: com.google.common.truth.AssertionErrorWithFacts at AbiExclusionsSpec.groovy:37

MGaetan89 avatar Aug 14 '24 13:08 MGaetan89

This plugin isn't just for Android, but also JVM projects. It's ok to make changes for AGP 8+, but the rest seems too aggressive.

Oops, my bad. I overlooked that. So for Android projects we can use Gradle 8.0+, and for JVM project it's Gradle 7.4+, correct?

MGaetan89 avatar Aug 14 '24 17:08 MGaetan89

So for Android projects we can use Gradle 8.0+, and for JVM project it's Gradle 7.4+, correct?

Yup.

autonomousapps avatar Aug 14 '24 21:08 autonomousapps

I won't have time to update this properly, so I'm closing this. I'll open a new PR if/when I can submit something targeting Android only.

MGaetan89 avatar Jan 17 '25 19:01 MGaetan89