talos icon indicating copy to clipboard operation
talos copied to clipboard

Return Analyze.best_params as dictionary

Open rlleshi opened this issue 5 years ago • 3 comments

Currently Reporting.best_params will return an array containing the best parameter values. However, it will not return the corresponding parameter names and this makes it difficult to tell apart which value stands for which parameter.

1) I think Talos should add

In commands/analyze.py, I think it would be better if best_params returned the complete dataframe (out) instead of the values (out.values)

2) Once implemented, I can see how this feature will

It will be easier to understand which values correspond to which parameters

3) I believe this feature is

nice to have

4) Given the chance, I'd be happy to make a PR for this feature

definitely


rlleshi avatar Sep 02 '20 19:09 rlleshi

Welcome to Talos community! Thanks so much for creating your first issue :)

github-actions[bot] avatar Sep 02 '20 19:09 github-actions[bot]

I think best make it into a dictionary. The goal here is to be able to feed back to the experiment programmatically.

mikkokotila avatar Nov 21 '20 12:11 mikkokotila

I second this. I have no idea how to read my best_params output. Documentation also needs to be added for the parameters of best_params(). exclude is required, but I don't know what it is.

NA-Dev avatar Mar 20 '21 18:03 NA-Dev