auto-sklearn icon indicating copy to clipboard operation
auto-sklearn copied to clipboard

AutoSklearn2Classifier.fit() contains metric

Open tornede opened this issue 3 years ago • 1 comments

Describe the bug

The fit-method of the AutoSklearn2Classifier contains a parameter metric, which is not used, and probably should not be there due to the according parameter in the constructor.

To Reproduce

Steps to reproduce the behavior:

  1. Go to AutoSklearn2Classifier.fit()
  2. Find the unused method parameter metric in the signature of that method.

Expected behavior

The metric parameter should be defined in the constructor, and not be given to the fit()-method.

Actual behavior, stacktrace or logfile

The metric parameter can be given to the fit() method, but is not used anywhere there.

Environment and installation:

None.

tornede avatar Sep 14 '22 08:09 tornede

Hi @tornede,

Thanks for the pointer, you're right and it should be removed! Will keep on the todo list for the next release :)

Best, Eddie

eddiebergman avatar Sep 14 '22 11:09 eddiebergman