node-machine-id icon indicating copy to clipboard operation
node-machine-id copied to clipboard

Switch windows to using native-reg to avoid permissions

Open Nokel81 opened this issue 4 years ago • 4 comments

Signed-off-by: Sebastian Malton [email protected]

fixes #56

Changes:

  • changing the code to be typescript
  • updating the package.json to reflect that change.
  • Fix the list and test scripts to run on windows git bash

Major change:

  • remove the calling of the reg.exe executable as that requires admin permissions. The native-reg package provides a JS compatible API to get the registry keys themselves.

Nokel81 avatar Jul 07 '21 19:07 Nokel81

How do I use it

weizhanzhan avatar Sep 02 '21 08:09 weizhanzhan

@weizhanzhan I don't understand what you are asking? We have to wait for @automation-stack to approve this PR before it would get merged.

Nokel81 avatar Oct 26 '21 18:10 Nokel81

When this PR will be merged @automation-stack

Rambarani avatar Jan 04 '22 02:01 Rambarani

I also need this changeset merged! @automation-stack

adambailey- avatar Jun 01 '22 21:06 adambailey-