node-machine-id
node-machine-id copied to clipboard
automation-stack
Fails if registry editing tools are disabled on windows
Hi, If you are on a restricted environment where local group policy prevent access to registry editing tools, the "REG QUERY" command fails. A workaround for me was to write a native tool (attached below), it work either on native and mixed environment.
Also seeing this issue as well, would it be possible to implement a fallback to the native tool or another nodejs way of accessing the registry if the REG QUERY command is detected as failed?
No @sweetevil, I still use my cpp workaround like that:
function getMachineIdSync() {
if (process.platform === 'win32') {
let guid = execSync('get-machine-guid.exe').toString()
guid = guid.replace(/\r+|\n+|\s+/ig, '').toLowerCase()
return createHash('sha256').update(guid).digest('hex')
}
else {
return machineIdSync()
}
A proper fix could be to implement it as a native module.
@eohland What is this get-machine-guid.exe ? You created exe file on your own or it is available online ?
I created my own, It is the compiled version of get-machine-guid.c included in my first post.
@eohland Does it return same machine Id in each case with machineIdSync & your workaround ?
@sweetevil Yes, the only difference is the way to retrieve the MachineGuid registry key
@sweetevil I just tried again and it compile without errors using the VS2015 Developer Command Prompt like this:
cl get-machine-guid.c
Here is the compiled executable : get-machine-guid.exe.zip
@eohland Your executable just flickers and returns nothing. I am getting undeclared KEY_WOW64_64KEY error while compiling script.
@eohland Nevermind, I got it working, just that I am having issues with returning char* buffer back from dll export method to the app. I am using node-ffi for dll comms.
Does this occur only is GP specifically "prevent access to registry editing tools" or is it if the user is not a local admin?
Late to the party but you can also use PowerShell:
const {spawnSync} = require('child_process');
const {createHash} = require('crypto');
const getSync = (original = false) => {
const psProc = 'powershell.exe';
const psArgs = ['-NoLogo', '-Command', '-NonInteractive', '(New-Object -ComObject WScript.Shell).RegRead("HKLM\\SOFTWARE\\Microsoft\\Cryptography\\MachineGuid")'];
const output = spawnSync(`${psProc}`, psArgs);
const string = output.stdout.toString().split('\r\n')[0];
return original ? string : hash(string);
};
function hash(guid) {
return createHash('sha256').update(guid).digest('hex');
}
module.exports = {
getSync,
};
