automatic-ripping-machine icon indicating copy to clipboard operation
automatic-ripping-machine copied to clipboard

werkzeug 2.2.0?

Open thepandaman2000 opened this issue 3 years ago • 9 comments

I'm a bit of a docker noob so please bear with me.

I'm attempting to run the arm in docker on unraid. When I launch the container is loops the following error in the log endlessly and fails to start the web ui.

Starting web ui Traceback (most recent call last): File "/opt/arm/arm/runui.py", line 8, in import arm.config.config as cfg # noqa E402 File "/opt/arm/arm/../arm/init.py", line 2, in import arm.ripper File "/opt/arm/arm/../arm/ripper/init.py", line 3, in from arm.ripper import logger, utils, makemkv, handbrake, identify # noqa F401 File "/opt/arm/arm/../arm/ripper/utils.py", line 24, in from arm.ui import app, db File "/opt/arm/arm/../arm/ui/init.py", line 13, in from flask_login import LoginManager File "/usr/local/lib/python3.8/dist-packages/flask_login/init.py", line 12, in from .login_manager import LoginManager File "/usr/local/lib/python3.8/dist-packages/flask_login/login_manager.py", line 35, in from .utils import _create_identifier File "/usr/local/lib/python3.8/dist-packages/flask_login/utils.py", line 14, in from werkzeug.routing import parse_rule ImportError: cannot import name 'parse_rule' from 'werkzeug.routing' (/usr/local/lib/python3.8/dist-packages/werkzeug/routing/init.py)

Some quick googling points to werkzeug 2.2.0 being the potential culprit

thepandaman2000 avatar Jul 27 '22 00:07 thepandaman2000

If youre having issues, please remember to read the wiki and follow the instructions carefully

github-actions[bot] avatar Jul 27 '22 00:07 github-actions[bot]

Never had this issue, but it looks like a routing issue specific to your unraid box. Please post the run command used when creating the container.

shitwolfymakes avatar Jul 27 '22 01:07 shitwolfymakes

This is part of an ongoing issue

https://github.com/1337-server/arm-dependencies/pull/26

The is because both Werkzeug and flask-login are being allowed to >= to the latest version. Instead of being pinned to specific versions.

But this causes issues as if pip gets werkz=>2.1.0, things break as it removed some functions and flask login didn't update their usages till versions 0.6.0. Meaning you can end up with newer versions of werkz, but older versions of flask login, breaking the images and installer scripts.

I have pushed a new commit to pin werkz to 2.0.3 and flask login to 0.5.0, this should be a temp fix, but something more stable will need to be found for long term.

Looks like the temp fix should work, as the tests all passed.
→ https://github.com/1337-server/arm-dependencies/actions/runs/2743558889

You can re-pull the image when this finishes building and all should be good. → https://github.com/1337-server/arm-dependencies/actions/runs/2743558890

1337-server avatar Jul 27 '22 01:07 1337-server

Thank you for your help. Having re-repulled from docker hub, I'm now getting a slightly different looping error:

Starting web ui [2022-07-27 09:26:36,077] DEBUG ARM: init. Debugging pin: 12345 Traceback (most recent call last): File "/opt/arm/arm/runui.py", line 8, in import arm.config.config as cfg # noqa E402 File "/opt/arm/arm/../arm/init.py", line 2, in import arm.ripper File "/opt/arm/arm/../arm/ripper/init.py", line 3, in from arm.ripper import logger, utils, makemkv, handbrake, identify # noqa F401 File "/opt/arm/arm/../arm/ripper/identify.py", line 20, in from arm.ui import utils as ui_utils File "/opt/arm/arm/../arm/ui/utils.py", line 18, in from werkzeug.routing import ValidationError ImportError: cannot import name 'ValidationError' from 'werkzeug.routing' (/usr/local/lib/python3.8/dist-packages/werkzeug/routing/init.py)

thepandaman2000 avatar Jul 27 '22 16:07 thepandaman2000

pulling from https://hub.docker.com/r/automaticrippingmachine/automatic-ripping-machine/

rather than https://hub.docker.com/r/1337server/automatic-ripping-machine/

seems to (at least in the short term) resolved the issue

thepandaman2000 avatar Jul 27 '22 18:07 thepandaman2000

Should be fixed now, I triggered a build of my own dockerhub. It hadn't been triggered on the main image, only the base image, as it takes 24h to update the main image automatically.

1337-server avatar Jul 27 '22 19:07 1337-server

That did it, thanks for your help

thepandaman2000 avatar Aug 01 '22 17:08 thepandaman2000

I might have spoken too soon, dvds seem to be working fine but when I tried a Blu-ray it seems to have crashed. I've attached a log below LATESPRING.log .

thepandaman2000 avatar Aug 01 '22 18:08 thepandaman2000

Docker image updated. Can you try the new image ?

1337-server avatar Aug 03 '22 22:08 1337-server

Closing as stale, feel free to reopen if the problem persists

shitwolfymakes avatar Feb 03 '23 00:02 shitwolfymakes