spicedb icon indicating copy to clipboard operation
spicedb copied to clipboard

Dispatch trailers are not present for all operations

Open jzelinskie opened this issue 3 years ago • 3 comments
trafficstars

Works as intended:

$ zed permission check resource:jirat manage user:cto --log-level=debug
4:20PM DBG set log level new level=debug
4:20PM DBG extracted response dispatch metadata cached=2 dispatch=0
false

Warns because they are not present:

$ zed schema read
4:20PM WRN error reading dispatched operations trailer error="key `io.spicedb.respmeta.dispatchedoperationscount` not found in trailer"
4:20PM WRN error reading cached operations trailer error="key `io.spicedb.respmeta.cachedoperationscount` not found in trailer"
definition user {}

$ zed relationship read resource:jira
4:20PM WRN error reading dispatched operations trailer error="key `io.spicedb.respmeta.dispatchedoperationscount` not found in trailer"
4:20PM WRN error reading cached operations trailer error="key `io.spicedb.respmeta.cachedoperationscount` not found in trailer"
resource:jira manager usergroup:engineering#manager
resource:jira viewer usergroup:engineering#member

jzelinskie avatar Jan 11 '22 21:01 jzelinskie

I think it's more than just schema operations, I think it's also read, write, and delete, all of which can do one or more downstream requests.

jakedt avatar Jan 11 '22 21:01 jakedt

We also need to set them even in the error path.

jzelinskie avatar Jan 12 '22 23:01 jzelinskie

We could have a middleware set them if not present to 1 operation and 0 cached?

josephschorr avatar Jun 07 '22 19:06 josephschorr