oidc-client-ts icon indicating copy to clipboard operation
oidc-client-ts copied to clipboard

Refresh Token issue with multiple tabs open

Open DASPRiD opened this issue 3 years ago • 13 comments

When a user has multiple tabs of an application open, and the refresh token is stored in either the session- or the local storage, both windows will try to use the refresh token at the same time.

This is an issue when the OIDC server uses refresh token rotation (which is a requirement to be able to store refresh tokens on the client), as whichever request goes through after the first will fail due to a deactivated refresh token.

The OIDC client should create a lock in the storage, so only one client does perform the refresh, while the other clients wait for the result of that client.

DASPRiD avatar Mar 18 '22 00:03 DASPRiD

@DASPRiD Would be really cool if you can find some time in the next few weeks to fix this.

pamapa avatar Jun 17 '22 06:06 pamapa

@DASPRiD and @pamapa I see several commits related to this issue, but it's also been pushed to milestone 2.0.6. Do we know what the state of this issue is, and whether it will be in 2.0.6?

CobusKruger avatar Aug 30 '22 07:08 CobusKruger

The development process is driven by @DASPRiD , but currently on hold because he had no time to finish. The way to implement should be agreed on. See MR #434. Would be nice if this can be finished sometime this year...

pamapa avatar Aug 30 '22 08:08 pamapa

Hi, just wondering what’s the status for this issue? It is a much needed feature.

felixfirefighter avatar Oct 17 '23 07:10 felixfirefighter

the implementation stuck, there is a good starting point here in MR #434, but there are some review comments which must be resolved first...

pamapa avatar Oct 18 '23 06:10 pamapa

Hi, just wondering what’s the status for this issue? It is a much needed feature.

timurscribe avatar Mar 19 '24 20:03 timurscribe

The implementation stalled, see MR #434. Would be excellent if somebody would take up that...

pamapa avatar Mar 21 '24 10:03 pamapa