auth0-deploy-cli icon indicating copy to clipboard operation
auth0-deploy-cli copied to clipboard

Fix preserve keywords in clientGrants audience

Open kushalshit27 opened this issue 1 year ago • 1 comments
trafficstars

🔧 Changes

When AUTH0_PRESERVE_KEYWORDS : true, export operation should preserve the mapping for audience key.

example:

clientGrants:
  - client_id: My Application
    audience: https://##AUTH0_DOMAIN##/api/v2/

📚 References

🔬 Testing

Added a new unit test cases to the main keyword preservation test with clientGrants resource.

📝 Checklist

  • [x] All new/changed/fixed functionality is covered by tests (or N/A)
  • [x] I have added documentation for all new/changed functionality (or N/A)

kushalshit27 avatar Sep 04 '24 09:09 kushalshit27

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.33%. Comparing base (0ac0038) to head (f951152).

Files with missing lines Patch % Lines
src/context/yaml/handlers/clientGrants.ts 90.90% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #952      +/-   ##
==========================================
+ Coverage   84.32%   84.33%   +0.01%     
==========================================
  Files         116      116              
  Lines        3802     3811       +9     
  Branches      745      748       +3     
==========================================
+ Hits         3206     3214       +8     
  Misses        329      329              
- Partials      267      268       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 04 '24 11:09 codecov-commenter

Closing this now, as this fix is not enough, I will investigate later.

kushalshit27 avatar Sep 25 '24 16:09 kushalshit27