David Vo

Results 309 comments of David Vo

data/playground/ is already excluded in the pre-commit config globally

> What is the currently recommended way to call a c++ function that wants a std::string argument from rust? Two options I'm aware of: - Write a C wrapper around...

Sounds right. In any case, opening the VSCode user settings JSON using the VSCode command and saving it would be the guaranteed correct way to create the settings file.

Curious what you find annoying specifically? We've still yet to update to pydantic 2.

We should probably stop autousing the robot fixture then, right? https://github.com/robotpy/pyfrc/blob/27fe979f7af9419c05c6c42c79f64d519781c089/pyfrc/test_support/pytest_plugin.py#L76

This is a bit of a killer for my team's code. Our unit tests each take noticeably longer to run with `--isolated`, doubling the total runtime of the tests (from...

pytest-xdist doesn't support this either, so if they don't have a solution I also don't think it's worth us spending the time.

FWIW github.dev (i.e. press . to open VS Code web) seems to fare okay at viewing this PR.

Having said that though, if scripting it isn't too hard, it might be easier to review such a script and land whatever changes it makes first.

For those playing along at home, this PR is waiting for https://github.com/Kitware/CMake/blob/master/Modules/Compiler/MSVC-CXX.cmake#L45-L46 to no longer use `-std:c++latest`, right?