google-translate icon indicating copy to clipboard operation
google-translate copied to clipboard

Change translation api's protocol from http to https

Open shigemk2 opened this issue 8 years ago • 7 comments

From http://translate.google.com to https://translate.google.com

shigemk2 avatar Oct 01 '17 07:10 shigemk2

This would be nice to merge :)

pierwill avatar Aug 15 '18 15:08 pierwill

Sure this one should be merged asap. v0.11.15 has been just released. Will see how it will be going and come back to this issue in order to merge and release. @pierwill @shigemk2 thank you!

atykhonov avatar Sep 26 '18 19:09 atykhonov

@atykhonov Thanks so much for this great package! This will make certain translation tasks much easier for me. Everything seems perfect so far, with this being the only flaw. I would appreciate it very much if you could merge this.

ylluminarious avatar Oct 08 '18 22:10 ylluminarious

I just tried the changes. Text translation works well, but sound translation doesn't work at all. And for now I don't see how to (quickly) fix this. Does it work for you?

atykhonov avatar Oct 19 '18 21:10 atykhonov

It looks like that I have some local issues when I play a sound (https-version) by means of mplayer or vlc (google-translate uses mplayer by default). For example, vlc reports an error "TLS client plugin not available". I can fix it and I will, but I think that these changes introduce a potential issue when a user doesn't have a player with TLS/SSL support and he cannot add that support. Also, I'm not sure how well the changes (for both, text and sound translations) will work on Windows machines (again the main concern is TLS/SSL support).

Overall, the idea is good, I think that google-translate should support these feature but it should be configurable by means of a flag that indicates which version to use: plain HTTP or HTTP over TLS/SSL (so, if you need encrypted communication you could turn it on). The default configuration should use insecure HTTP.

atykhonov avatar Oct 19 '18 21:10 atykhonov

@atykhonov That sounds reasonable to me.

ylluminarious avatar Oct 20 '18 01:10 ylluminarious

@ylluminarious thanks for your feedback! I'll do my best to implement the feature in the nearest future.

atykhonov avatar Oct 24 '18 02:10 atykhonov