conditional-flow-matching icon indicating copy to clipboard operation
conditional-flow-matching copied to clipboard

Published 20 hours ago • verified publisher icon atong01

Incorrect implementation of `TargetConditionalFlowMatcher`

Open Rattko opened this issue 9 months ago • 3 comments

Hey,

I've been experimenting with Conditional Flow Matching for a paper I'm currently working on and I've noticed that you have an incorrect implementation of TargetConditionalFlowMatcher, in particular, the sample_xt and compute_conditional_flow methods. The current implementation (rewritten 1:1 in Jax) completely fails to learn even the simplest distributions.

I believe that sample_xt should use x0 instead of epsilon and compute_conditional_flow should return x1 - (1 - self.sigma) * x0 instead of what it currently returns.

Hope this helps ;)

Rattko avatar Jan 05 '25 15:01 Rattko