node-keytar icon indicating copy to clipboard operation
node-keytar copied to clipboard

`FindCredentials` call on Linux without unlocking the key store crashes

Open jsimonet opened this issue 3 years ago • 0 comments

Prerequisites

Some prerequisites are not applicable since I did not used Atom to develop the fix and check for testing.

Description

FindCredentials call on Linux without unlocking the key store crashes.

  (process:280213): libsecret-CRITICAL **: 16:09:20.426: secret_value_get_text: assertion 'value' failed

Steps to Reproduce

  1. Ensure the key store is locked
  2. call FindCredentials
  3. Click on "Cancel" when password is asked for unlocking the keystore

Expected behavior:

A crash does not happens.

Actual behavior:

A crash does happens.

Reproduces how often:

100% of the time.

Versions

Not using Atom for testing, using another Electron application.

Linux Manjaro Release: 22.0.0.

Additional Information

jsimonet avatar Nov 07 '22 15:11 jsimonet