node-keytar icon indicating copy to clipboard operation
node-keytar copied to clipboard

return service also in "findCredentials"

Open TqrHsn opened this issue 6 years ago • 2 comments

"findCredentials" method performs a wildcard search on all service entries. So, with the result array {account, password} it is impossible to determine which service is it referring to. It would be better if it returns array {service, account, password}.

More details: My app supports adding multiple credentials with a prefix like "my-app:service1", "my-app:service2" and so on. So when I call findCredentials("my-app"), it returns all the entries for my-app but I am unable to determine which result entry is referring to which service. This can be solved if method returns {service, account, password} instead of just {account, password}.

TqrHsn avatar Dec 17 '18 08:12 TqrHsn

Marking this as help-wanted because I think this is some low-hanging fruit for someone to contribute:

This can be solved if method returns {service, account, password} instead of just {account, password}.

shiftkey avatar Jan 21 '19 20:01 shiftkey

It looks like windows is the only platform that performs a wildcard search. So @shiftkey , for mac and linux, all results should have the same service, right?

MRayermannMSFT avatar Dec 05 '19 18:12 MRayermannMSFT