terminal icon indicating copy to clipboard operation
terminal copied to clipboard

The terminal size is not correct

Open aminya opened this issue 5 years ago • 9 comments

It does not cover all the tab when I used terminal:open.

image

It is correct in the bottom tab. image

aminya avatar Sep 17 '20 06:09 aminya

I also get strange line issues because of this: image

aminya avatar Sep 17 '20 08:09 aminya

I can reproduce this. It seems to be an issue with fit getting the wrong initial dimensions. I will have to play around with it for a while to figure out why.

After it happens if I resize the window it works correctly so the issue might be that we need to create the terminal after a short delay.

UziTech avatar Sep 17 '20 18:09 UziTech

Actually it looks like fit is returning the correct dimensions so I think this is an xterm bug but I am not sure.

UziTech avatar Sep 17 '20 18:09 UziTech

Well, I don't have this issue with x-terminal. I think the problem is in the terminal itself.

aminya avatar Sep 17 '20 19:09 aminya

It seems to happen intermittently with x-terminal. I'm guessing it is a race condition. I have confirmed that running refitTerminal() on a setTimeout after createTerminal() fixes it (or at least hides the problem).

UziTech avatar Sep 17 '20 19:09 UziTech

That seems a good solution for now! We can investigate the issue more later, maybe in the xterm repo itself.

aminya avatar Sep 17 '20 19:09 aminya

Should we create a xterm issue for this?

aminya avatar Sep 24 '20 15:09 aminya

I'm not 100% sure if this is an issue in xterm or an issue with the way that Atom opens panes.

UziTech avatar Sep 24 '20 15:09 UziTech

When I resize the terminal, the last line is not updated. It makes the last line go to an empty space. I should press CTRL+L to fix this.

Screenshot 2021-08-07 054712

aminya avatar Aug 07 '21 17:08 aminya