camelot icon indicating copy to clipboard operation
camelot copied to clipboard

Add ability to read file object

Open simonghrt opened this issue 6 years ago • 4 comments

A function read_file_object has been added in order to be able to directly read a file object (useful for many usecases)

simonghrt avatar Sep 17 '19 09:09 simonghrt

This PR is based on [https://github.com/atlanhq/camelot/pull/331](this one) as it's the same use case. I added a test and modified the code in a simpler way (and following PEP8 guidelines). I've read your previous comment about the read_file_obj in the main interface but I didn't see any other alternatives. Let me know if you wish any modifications

simonghrt avatar Sep 17 '19 09:09 simonghrt

just realizing this is a somewhat old? repository?

@simonghrt if you read this, resend the pull request over here:

  • https://github.com/camelot-dev/camelot

yeus avatar Oct 05 '20 21:10 yeus

It would be really nice to get this functionality in camelot. @simonghrt Can you create a new PR for the camelot-dev repo?

FelixSchwarz avatar Jan 31 '22 14:01 FelixSchwarz

We'd also love this over using tempfile!

stevenkissack avatar Jun 16 '22 07:06 stevenkissack